From 912bd7da077f4b6cd0ee89e67958133139648a07 Mon Sep 17 00:00:00 2001
From: Patrick Jentsch <p.jentsch@uni-bielefeld.de>
Date: Fri, 30 Jun 2023 14:18:07 +0200
Subject: [PATCH] Remove TODOs that are done
---
app/static/js/CorpusAnalysis/CorpusAnalysisApp.js | 1 -
app/static/js/CorpusAnalysis/CorpusAnalysisConcordance.js | 4 ++--
app/static/js/CorpusAnalysis/CorpusAnalysisReader.js | 2 --
3 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/app/static/js/CorpusAnalysis/CorpusAnalysisApp.js b/app/static/js/CorpusAnalysis/CorpusAnalysisApp.js
index 5fb34855..3b0213d0 100644
--- a/app/static/js/CorpusAnalysis/CorpusAnalysisApp.js
+++ b/app/static/js/CorpusAnalysis/CorpusAnalysisApp.js
@@ -55,7 +55,6 @@ class CorpusAnalysisApp {
this.elements.m.initModal.close();
},
(cqiError) => {
- // TODO: CHECK THIS!
let errorsElement = this.elements.initModal.querySelector('.errors');
let progressElement = this.elements.initModal.querySelector('.progress');
errorsElement.innerText = JSON.stringify(cqiError);
diff --git a/app/static/js/CorpusAnalysis/CorpusAnalysisConcordance.js b/app/static/js/CorpusAnalysis/CorpusAnalysisConcordance.js
index 7c9b57c1..dc1ee3a2 100644
--- a/app/static/js/CorpusAnalysis/CorpusAnalysisConcordance.js
+++ b/app/static/js/CorpusAnalysis/CorpusAnalysisConcordance.js
@@ -292,7 +292,7 @@ class CorpusAnalysisConcordance {
event.preventDefault();
let subcorpus = this.data.subcorpora[this.settings.selectedSubcorpus];
subcorpus.o.drop().then(
- cQiStatus => {
+ (cQiStatus) => {
app.flash(`${subcorpus.o.name} deleted`, 'corpus');
delete this.data.subcorpora[subcorpus.o.name];
this.settings.selectedSubcorpus = undefined;
@@ -313,7 +313,7 @@ class CorpusAnalysisConcordance {
this.clearSubcorpusPagination();
}
},
- cQiError => {
+ (cQiError) => {
app.flash(`${cQiError.payload.code}: ${cQiError.payload.msg}`, 'error');
}
);
diff --git a/app/static/js/CorpusAnalysis/CorpusAnalysisReader.js b/app/static/js/CorpusAnalysis/CorpusAnalysisReader.js
index 49b5538f..33dd6f47 100644
--- a/app/static/js/CorpusAnalysis/CorpusAnalysisReader.js
+++ b/app/static/js/CorpusAnalysis/CorpusAnalysisReader.js
@@ -28,7 +28,6 @@ class CorpusAnalysisReader {
init() {
// Init data
this.data.corpus = this.app.data.corpus;
- this.data.subcorpora = {}; // TODO: DO WE NEED THIS HERE?
// Add event listeners
this.elements.form.addEventListener('submit', (event) => {
event.preventDefault();
@@ -46,7 +45,6 @@ class CorpusAnalysisReader {
this.app.enableActionElements();
},
(cqiError) => {
- // TODO: CHECK THIS!
this.elements.error.innerText = JSON.stringify(error);
this.elements.error.classList.remove('hide');
if ('payload' in error && 'code' in error.payload && 'msg' in error.payload) {
--
GitLab