From d6b772c2e8b3fdd2639b00bb3f7c99bb7886f92d Mon Sep 17 00:00:00 2001
From: Patrick Jentsch <p.jentsch@uni-bielefeld.de>
Date: Thu, 5 Jan 2023 08:11:27 +0100
Subject: [PATCH] Remove helper comments
---
app/static/js/ResourceLists/CorpusFileList.js | 6 +-----
app/static/js/ResourceLists/CorpusList.js | 5 +----
app/static/js/ResourceLists/JobInputList.js | 6 +-----
app/static/js/ResourceLists/JobList.js | 6 +-----
app/static/js/ResourceLists/JobResultList.js | 6 +-----
app/static/js/ResourceLists/PublicUserList.js | 6 +-----
app/static/js/ResourceLists/SpacyNLPPipelineModelList.js | 6 +-----
.../js/ResourceLists/TesseractOCRPipelineModelList.js | 6 +-----
app/static/js/ResourceLists/UserList.js | 6 +-----
9 files changed, 9 insertions(+), 44 deletions(-)
diff --git a/app/static/js/ResourceLists/CorpusFileList.js b/app/static/js/ResourceLists/CorpusFileList.js
index 4549c503..9fc7c7f1 100644
--- a/app/static/js/ResourceLists/CorpusFileList.js
+++ b/app/static/js/ResourceLists/CorpusFileList.js
@@ -22,7 +22,6 @@ class CorpusFileList extends ResourceList {
});
}
- // #region Mandatory getters and methods to implement
get item() {
return `
<tr class="clickable hoverable">
@@ -76,9 +75,7 @@ class CorpusFileList extends ResourceList {
<ul class="pagination"></ul>
`.trim();
}
- // #endregion
-
- // #region Optional methods to implement
+
mapResourceToValue(corpusFile) {
return {
'id': corpusFile.id,
@@ -93,7 +90,6 @@ class CorpusFileList extends ResourceList {
sort() {
this.listjs.sort('creation-date', {order: 'desc'});
}
- // #endregion
onClick(event) {
let corpusFileElement = event.target.closest('tr');
diff --git a/app/static/js/ResourceLists/CorpusList.js b/app/static/js/ResourceLists/CorpusList.js
index 1c7ccb81..c8122894 100644
--- a/app/static/js/ResourceLists/CorpusList.js
+++ b/app/static/js/ResourceLists/CorpusList.js
@@ -71,9 +71,7 @@ class CorpusList extends ResourceList {
<ul class="pagination"></ul>
`.trim();
}
- // #endregion
-
- // #region Optional methods to implement
+
mapResourceToValue(corpus) {
return {
'id': corpus.id,
@@ -87,7 +85,6 @@ class CorpusList extends ResourceList {
sort() {
this.listjs.sort('creation-date', {order: 'desc'});
}
- // #endregion
onClick(event) {
let corpusElement = event.target.closest('tr');
diff --git a/app/static/js/ResourceLists/JobInputList.js b/app/static/js/ResourceLists/JobInputList.js
index 02b20df4..ce537084 100644
--- a/app/static/js/ResourceLists/JobInputList.js
+++ b/app/static/js/ResourceLists/JobInputList.js
@@ -22,7 +22,6 @@ class JobInputList extends ResourceList {
});
}
- // #region Mandatory getters and methods to implement
get item() {
return `
<tr class="clickable hoverable">
@@ -65,9 +64,7 @@ class JobInputList extends ResourceList {
<ul class="pagination"></ul>
`.trim();
}
- // #endregion
-
- // #region Optional methods to implement
+
mapResourceToValue(jobInput) {
return {
'id': jobInput.id,
@@ -79,7 +76,6 @@ class JobInputList extends ResourceList {
sort() {
this.listjs.sort('filename', {order: 'asc'});
}
- // #endregion
onClick(event) {
let jobInputElement = event.target.closest('tr');
diff --git a/app/static/js/ResourceLists/JobList.js b/app/static/js/ResourceLists/JobList.js
index 6800b520..de4b2ee8 100644
--- a/app/static/js/ResourceLists/JobList.js
+++ b/app/static/js/ResourceLists/JobList.js
@@ -21,7 +21,6 @@ class JobList extends ResourceList {
});
}
- // #region Mandatory getters and methods to implement
get item() {
return `
<tr class="clickable hoverable service-scheme">
@@ -72,9 +71,7 @@ class JobList extends ResourceList {
<ul class="pagination"></ul>
`.trim();
}
- // #endregion
-
- // #region Optional methods to implement
+
mapResourceToValue(job) {
return {
'id': job.id,
@@ -89,7 +86,6 @@ class JobList extends ResourceList {
sort() {
this.listjs.sort('creation-date', {order: 'desc'});
}
- // #endregion
onClick(event) {
let jobElement = event.target.closest('tr');
diff --git a/app/static/js/ResourceLists/JobResultList.js b/app/static/js/ResourceLists/JobResultList.js
index 06bd20ec..282a4ba1 100644
--- a/app/static/js/ResourceLists/JobResultList.js
+++ b/app/static/js/ResourceLists/JobResultList.js
@@ -22,7 +22,6 @@ class JobResultList extends ResourceList {
});
}
- // #region Mandatory getters and methods to implement
get item() {
return `
<tr class="clickable hoverable">
@@ -68,9 +67,7 @@ class JobResultList extends ResourceList {
<ul class="pagination"></ul>
`.trim();
}
- // #endregion
-
- // #region Optional methods to implement
+
mapResourceToValue(jobResult) {
return {
'id': jobResult.id,
@@ -83,7 +80,6 @@ class JobResultList extends ResourceList {
sort() {
this.listjs.sort('filename', {order: 'asc'});
}
- // #endregion
onClick(event) {
let jobResultElement = event.target.closest('tr');
diff --git a/app/static/js/ResourceLists/PublicUserList.js b/app/static/js/ResourceLists/PublicUserList.js
index 447ff3fe..39974349 100644
--- a/app/static/js/ResourceLists/PublicUserList.js
+++ b/app/static/js/ResourceLists/PublicUserList.js
@@ -10,7 +10,6 @@ class PublicUserList extends ResourceList {
this.listjs.list.addEventListener('click', (event) => {this.onClick(event)});
}
- // #region Mandatory getters and methods to implement
get item() {
return `
<tr class="clickable hoverable">
@@ -68,9 +67,7 @@ class PublicUserList extends ResourceList {
<ul class="pagination"></ul>
`.trim();
}
- // #endregion
-
- // #region Optional methods to implement
+
mapResourceToValue(user) {
return {
'id': user.id,
@@ -87,7 +84,6 @@ class PublicUserList extends ResourceList {
sort() {
this.listjs.sort('member-since', {order: 'desc'});
}
- // #endregion
onClick(event) {
let actionButtonElement = event.target.closest('.action-button');
diff --git a/app/static/js/ResourceLists/SpacyNLPPipelineModelList.js b/app/static/js/ResourceLists/SpacyNLPPipelineModelList.js
index 8f820959..6e1bbc30 100644
--- a/app/static/js/ResourceLists/SpacyNLPPipelineModelList.js
+++ b/app/static/js/ResourceLists/SpacyNLPPipelineModelList.js
@@ -30,7 +30,6 @@ class SpaCyNLPPipelineModelList extends ResourceList {
});
}
- // #region Mandatory getters and methods to implement
get item() {
return `
<tr class="clickable hoverable">
@@ -95,9 +94,7 @@ class SpaCyNLPPipelineModelList extends ResourceList {
<ul class="pagination"></ul>
`.trim();
}
- // #endregion
-
- // #region Optional methods to implement
+
mapResourceToValue(spaCyNLPPipelineModel) {
return {
'id': spaCyNLPPipelineModel.id,
@@ -118,7 +115,6 @@ class SpaCyNLPPipelineModelList extends ResourceList {
sort() {
this.listjs.sort('creation-date', {order: 'desc'});
}
- // #endregion
onChange(event) {
let actionSwitchElement = event.target.closest('.action-switch');
diff --git a/app/static/js/ResourceLists/TesseractOCRPipelineModelList.js b/app/static/js/ResourceLists/TesseractOCRPipelineModelList.js
index 98506537..4a9827f4 100644
--- a/app/static/js/ResourceLists/TesseractOCRPipelineModelList.js
+++ b/app/static/js/ResourceLists/TesseractOCRPipelineModelList.js
@@ -30,7 +30,6 @@ class TesseractOCRPipelineModelList extends ResourceList {
});
}
- // #region Mandatory getters and methods to implement
get item() {
return `
<tr class="clickable hoverable">
@@ -95,9 +94,7 @@ class TesseractOCRPipelineModelList extends ResourceList {
<ul class="pagination"></ul>
`.trim();
}
- // #endregion
-
- // #region Optional methods to implement
+
mapResourceToValue(tesseractOCRPipelineModel) {
return {
'id': tesseractOCRPipelineModel.id,
@@ -118,7 +115,6 @@ class TesseractOCRPipelineModelList extends ResourceList {
sort() {
this.listjs.sort('creation-date', {order: 'desc'});
}
- // #endregion
onChange(event) {
let actionSwitchElement = event.target.closest('.action-switch');
diff --git a/app/static/js/ResourceLists/UserList.js b/app/static/js/ResourceLists/UserList.js
index e2ee891b..aedba114 100644
--- a/app/static/js/ResourceLists/UserList.js
+++ b/app/static/js/ResourceLists/UserList.js
@@ -10,7 +10,6 @@ class UserList extends ResourceList {
this.listjs.list.addEventListener('click', (event) => {this.onClick(event)});
}
- // #region Mandatory getters and methods to implement
get item() {
return `
<tr class="clickable hoverable">
@@ -67,9 +66,7 @@ class UserList extends ResourceList {
<ul class="pagination"></ul>
`.trim();
}
- // #endregion
-
- // #region Optional methods to implement
+
mapResourceToValue(user) {
return {
'id': user.id,
@@ -85,7 +82,6 @@ class UserList extends ResourceList {
sort() {
this.listjs.sort('member-since', {order: 'desc'});
}
- // #endregion
onClick(event) {
let userElement = event.target.closest('tr');
--
GitLab