Skip to content
Snippets Groups Projects
todo 1.41 KiB
Newer Older
  • Learn to ignore specific revisions
  • Olivier Bertrand's avatar
    Olivier Bertrand committed
    ------------------------------------------------------
    0003: Improve database
    In the init database I would like to use class properties instead of get/read
    line: 263,273,and 394
        def create(self)
    should be replaced by:
        @property
        def create(self)
    
    It implies that at every point that self.create() is called should be changed to self.create [Note the absence of parenthesis]
    
    line: 298
        def get_posorients(self) 
    should be replaced by
        @property
        def posorients(self)
    
    Need to propagate the changes through all the code (see rendering / processing / moving )
    
    
    Should be done, but maybe I missed something?
    
    Olivier Bertrand's avatar
    Olivier Bertrand committed
    
    ------------------------------------------------------
    0005: Write test function for raise Error
    - for every raise error create a test function, checking that the error is correctly thrown (see moving/test_agent for inspiration)
    
    
    also should be done. But I did not add any more checks to the moving part, shall I check for additional possible checks?
    
    --------------------------------------------------------------------
    0009: can the last dimension (4) of the place-code be greater 1? (should be 1)
    
    Olivier Bertrand's avatar
    Olivier Bertrand committed
        Yes it can, see apcv a [1x1x1x3] array 
    
    0010: what is the image in the database? must it be transformed to a a scene?
    
    Olivier Bertrand's avatar
    Olivier Bertrand committed
        The image is an image, and distance the distance. I added scene as a join image+distance array
    
        now we do not have a  read_image function in database anymore, is it supposed to be like this?