Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P PRIMO
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 8
    • Issues 8
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Social Cognitive SystemsSocial Cognitive Systems
  • PRIMO
  • Merge requests
  • !22

Only add edges in factor Tree when node is connected in BN

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jan Pöppel requested to merge jpoeppel:factorBug into master Oct 09, 2017
  • Overview 0
  • Commits 5
  • Changes 2

Created by: jpoeppel

This PR fixes a small error that nodes that have not been connected in the BN (therefore useless nodes) where still connected to the resulting factortree. While this did not really cause an issue when that node contained a valid CPT, it did cause a FloatingPointError: divide by zero encountered in true_divide error, when the CPT of the unconnected node was not set upon setting evidence/message passing.

Fixes #21 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: jpoeppel:factorBug