Resolve "Sort by created timestamp descending when getting the latest version"

Closes #51 (closed)

app/api/endpoints/workflow.py

@@ -146,7 +146,7 @@ async def create_workflow(
     # Create the workflow in the DB
     workflow_db = await CRUDWorkflow.create(db, workflow, current_user.uid)
 
-    # If it is a private repository, create a SCM file and upload it to the params bucket
+    # If it is a private repository, create an SCM file and upload it to the params bucket
     scm_provider = Provider.from_repo(repo, name=f"repo{workflow_db.workflow_id.hex}")
     if scm_provider is not None:
         background_tasks.add_task(
@@ -154,7 +154,7 @@ async def create_workflow(
         )
 
     # If there are workflow modes with alternative parameter schemas, cache them in the WORKFLOW Bucket
-    if workflow.modes is not None and len(workflow.modes) > 0:
+    if len(workflow.modes) > 0:
         for mode_db in workflow_db.versions[0].workflow_modes:
             background_tasks.add_task(
                 repo.copy_file_to_bucket,
@@ -361,7 +361,7 @@ async def update_workflow(
     # Get modes of previous version
     previous_version_modes = await CRUDWorkflowMode.list_modes(db, previous_version.git_commit_hash)
 
-    if version_update.delete_modes is not None:
+    if len(version_update.delete_modes) > 0:
         # Check if mode to delete actually exist
         mode_ids = [mode.mode_id for mode in previous_version_modes]
         for delete_mode in version_update.delete_modes:
@@ -384,13 +384,13 @@ async def update_workflow(
 
     check_repo_modes = previous_version_modes.copy()
     # If there are new modes, add them to the list for file checking
-    if version_update.append_modes is not None:
+    if len(version_update.append_modes) > 0:
         check_repo_modes += version_update.append_modes
     await check_repo(repo=repo, client=client, modes=check_repo_modes)
 
     append_modes_db: List[WorkflowMode] = []
     # Create new modes in database
-    if version_update.append_modes is not None:
+    if len(version_update.append_modes) > 0:
         append_modes_db = await CRUDWorkflowMode.create(db, version_update.append_modes)
     # Make a list with all DB modes of modes for the new workflow version
     db_modes = previous_version_modes + append_modes_db